Add methods to StreamWrapper to allow better pickling
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures seem unrelated and are due to #330. |
|
LGTM. The checks that didn't pass are unrelated to this change. I'm merging this but please be aware that since colorama is currently stable and widely use, its release cadence is very slow, so I can't guarantee when this fix will be included in an official release. |
|
@wiggin15 Are there any open issues that would help speed up the release of a patch release? I'm not sure how many users use |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86.
The popular python linter
pylinthas updated its pickler module from thestdlibpickleto the widely useddillpackage. However, users have run into issues with this ascoloramaapparently does not support pickling bydill. One user already identified this issue 6 years ago, but a fix was never submitted.The following fixes the issue and passes all tests. We would appreciate if this could get merged as
pylintis somewhat unable to return topicklebut we also don't want to stop supportingcolorama.As for a test, I didn't want to add
dillas a test dependency, but that would be the easiest way to test this I think. Just trying to pickleStreamWrapperwithdillwould fail without the code in this PR.