Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue71 readme tidy #72

Merged
merged 3 commits into from
Oct 21, 2015
Merged

Issue71 readme tidy #72

merged 3 commits into from
Oct 21, 2015

Conversation

tartley
Copy link
Owner

@tartley tartley commented Sep 25, 2015

A start towards addressing #71

Most of the diffs are contentless whitespace faffing - I like to view things in an 80 char terminal. My apologies.

The only substantive changes are:

  • I removed my own email address as a suggested project 'contact' (because I no longer actively contribute these days)
  • I removed contributor Jesse's email address from this public README. (Sorry Jesse!)
  • I added the word 'contact' to the link to the colorama discussion group, so that people doing 'find in page' for 'contact' will find it.

@wiggin15
Copy link
Collaborator

Thanks! More things to consider:

  • Remove this line: "Ask Jonathan for commit rights, you'll get them."
  • Remove the Thanks section? Of course I don't want to remove any ACK to contributors, but most of this list duplicates entries in the changelog, and I'm not sure the README is the place for this. Maybe we need to find the names not mentioned in the changelog, find how they contributed, and move them to the changelog. Alternatively, create a separate file for ACKs (I saw other projects using it, e.g. psutil and Python itself). This is just a suggestion - what do you think?
  • Your name should be more prominent than a single line at the bottom :)

wiggin15 added a commit that referenced this pull request Oct 21, 2015
@wiggin15 wiggin15 merged commit 3b3c3bd into master Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants