Bug Fix: Race condition

cmd/talosplus/subcmd/run.go

@@ -8,6 +8,7 @@ import (
 	"github.com/spf13/cobra"
 	"github.com/tarunKoyalwar/talosplus/pkg/alerts"
 	"github.com/tarunKoyalwar/talosplus/pkg/core"
+	"github.com/tarunKoyalwar/talosplus/pkg/ioutils"
 	"github.com/tarunKoyalwar/talosplus/pkg/shared"
 	"github.com/tarunKoyalwar/talosplus/pkg/shell"
 )
@@ -16,7 +17,7 @@ import (
 var (
 	limit   = 4 // max number of concurrent programs
 	Purge   = false
-	Verbose = true
+	Verbose = false
 
 	CachedDir    = os.TempDir()
 	DiscordId    = ""
@@ -73,6 +74,9 @@ Settings Like  Purge, CacheDIR , pname etc can also be set using "get|set"
 			shell.Settings.CacheDIR = cdirenv
 		}
 
+		//debug mode
+		ioutils.Cout.Verbose = Verbose
+
 		// Configure Notifications if given
 		SetupAlerts()
 

pkg/core/crux.go

@@ -202,6 +202,11 @@ func (s *Scripter) Execute() {
 			s.Backup = append(s.Backup, b)
 
 		} else {
+			instance := s.IndexedCMDs[resp.Uid]
+			if instance != nil {
+				ioutils.Cout.Printf("[Failed] %v\n", strings.Join(instance.CMD.Cmdsplit, " "))
+			}
+
 			ioutils.Cout.Printf("[-] %v responded with error %v\n", resp.Uid, resp.Err)
 		}
 	}

pkg/gopool/pool.go

@@ -1,19 +1,11 @@
 package gopool
 
 import (
-	"reflect"
 	"sync"
 
 	"github.com/tarunKoyalwar/talosplus/pkg/shell"
 )
 
-const mutexLocked = 1
-
-func MutexLocked(m *sync.Mutex) bool {
-	state := reflect.ValueOf(m).Elem().FieldByName("state")
-	return state.Int()&mutexLocked == mutexLocked
-}
-
 // Pool : Goroutine Pool with Limit
 type Pool struct {
 	Concurrency int
@@ -30,6 +22,7 @@ type Pool struct {
 	logic    *sync.WaitGroup // Handles shared Working of Pool
 	Wg       *sync.WaitGroup // Wait Group For Launched Jobs
 	JobMutex *sync.Mutex
+	JobSent  int
 }
 
 // AddJob
@@ -40,6 +33,7 @@ func (p *Pool) AddJob(t *shell.CMDWrap) {
 	}
 
 	p.JobChannel <- j
+	p.JobSent += 1
 }
 
 // AddJobWithId
@@ -50,6 +44,7 @@ func (p *Pool) AddJobWithId(t *shell.CMDWrap, uid string) {
 	}
 
 	p.JobChannel <- j
+	p.JobSent += 1
 }
 
 // Launcher : (shared)Launches New Jobs assings workers etc
@@ -162,12 +157,13 @@ func (p *Pool) Wait() {
 
 	p.JobMutex.Lock()
 
-	if p.JobCount == 0 {
+	if p.JobCount == 0 && p.JobSent == 0 {
 		p.JobMutex.Unlock()
 		return
 	}
 	p.JobMutex.Unlock()
 	<-p.Completion
+	p.JobSent = 0
 }
 
 func NewPool(size int) *Pool {

pkg/shell/basic.go

@@ -90,9 +90,12 @@ func (s *SimpleCMD) Run() error {
 		if err != nil {
 			ioutils.Cout.PrintWarning("[error] %v", err)
 			s.Failed = true
+			return err
 		}
-		io.WriteString(stdin, s.CPipeIn.String())
-		stdin.Close()
+		func() {
+			defer stdin.Close()
+			io.WriteString(stdin, s.CPipeIn.String())
+		}()
 	}
 
 	err := c.Run()