XKCD 961 Eternal Flame animated gif

[antonc42]

https://xkcd.com/961/

The image is an animated gif, but is renamed with .jpg extension when downloaded.

[tasdikrahman]

Hey @antonc42 Looks like this is an edge case. Will take a look over the weekend. If someone is up to it. There's not much to patch here. So feel free to make a PR Cheers!

…

On May 26, 2017 8:53 PM, "antonc42" ***@***.***> wrote: https://xkcd.com/961/ The image is an animated gif, but is renamed with .jpg extension when downloaded. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#37>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdMBkTSaxIDws-EcQlmYyfzFohwscUfks5r9u5hgaJpZM4Nnu2z> .

[antonc42]

After looking, it does seem to be a simple fix. I submitted a PR #38. I tested it by downloading all the comics again and it found a few more gifs than just 961. There was also 1116, 1264, and 1331.

[tasdikrahman]

Good work @antonc42 👍

Thanks for the contribution. Will update the pip module in a while

[antonc42]

No problem! Thank you for the awesome app!

[tasdikrahman]

I am glad you liked it @antonc42 :) Do you use it quite frequently?

…

On Sat, May 27, 2017 at 9:22 PM, antonc42 ***@***.***> wrote: No problem! Thank you for the awesome app! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#37 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdMBnrNJAlzOvHUI7yi1eY7UF405jPlks5r-EbOgaJpZM4Nnu2z> .

[antonc42]

I just discovered it recently. I'm using it to create a screensaver slideshow of the comics.

[tasdikrahman]

Ah. That's nice. Would be great if you can share how did you find xkcd-dl, was curious about it?

And please keep me posted on this project of yours. Would love to have a look at it.

Cheers!

[antonc42]

There's not really much to it. I use your app to download all the comics to a directory and then point my screensaver at it. The only other thing I did was to put the alt text at the bottom of the image. I just do that with a little bash script. https://gist.github.com/antonc42/01742c560eb741b4ca543c966fe22cc0

[tasdikrahman]

Looks good man. @antonc42

Would love to put your project on the README.md under a title like projects using xkcd-dl if you don't mind

[antonc42]

Sure, fine by me.