This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Move xkcd_dict.json to HomeDir and Download xkcd in WorkingDir #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have solved requests 1 and 2 of Issue #6: I've changed all of the logical to assume that xkcd_dict.json will be in the home dir. I've changed the download functions to download the xkcd files to the working dir of the terminal.
Closed
|
The newest commit (e11a0f9) should make the paths OS independent. I will test all README methods listed soon. |
|
The last commit (597430c) has been tested and all commands are confirmed to work on Ubuntu 14. |
tasdikrahman
pushed a commit
that referenced
this pull request
Jan 6, 2016
Move xkcd_dict.json to HomeDir and Download xkcd in WorkingDir by @Kickball
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have solved requests 1 and 2 of Issue #6:
I've changed all of the logical to assume that
xkcd_dict.jsonwill be in the home dir.I've changed the download functions to download the xkcd files to the working dir of the terminal.
Note:
This is tested to work on Ubuntu 14, however it may have issues with Windows due to use of / (and possible use of \ in Windows file system). I don't have a Windows machine to test with.
Should the above issue pose a problem we would have to check the operating system when the script is first run and use appropriate slashes.