Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation to force account removal after app uninstallation #295

Closed
marcelomorgado opened this issue Apr 16, 2019 · 9 comments · Fixed by #331
Closed

Preparation to force account removal after app uninstallation #295

marcelomorgado opened this issue Apr 16, 2019 · 9 comments · Fixed by #331
Labels
bug Something isn't working important and urgent
Milestone

Comments

@marcelomorgado
Copy link
Contributor

iOS is keeping the user's account after app uninstallation (Related to: #289 (comment)).
This behavior happens with SecureStore only. To solve it, alike isFirstAppUse should be persisted on AsyncStore and if the condition isFirstAppUse && retrieveEphemeralAccount() != null the stored account should be removed.

@marcelomorgado marcelomorgado added the bug Something isn't working label Apr 16, 2019
@marcelomorgado marcelomorgado added this to the 0.1.0 release milestone Apr 16, 2019
@pcowgill
Copy link
Member

Might be worth noting for posterity that this issue is a short-term solution, and we might not keep this behavior in the long run

@pcowgill
Copy link
Member

This PR is probably worth making this week

@pcowgill
Copy link
Member

@marcelomorgado If it ends up being easier, a button on the my account screen that lets you manually purge your account would work too. That might even be a better UX

@pcowgill
Copy link
Member

@marcelomorgado If it ends up being easier, a button on the my account screen that lets you manually purge your account would work too. That might even be a better UX

Curious for your thoughts on this

@marcelomorgado
Copy link
Contributor Author

marcelomorgado commented Apr 19, 2019

@marcelomorgado If it ends up being easier, a button on the my account screen that lets you manually purge your account would work too. That might even be a better UX

Curious for your thoughts on this

I was thinking about it, maybe worth forcing the removal to keep the same behavior on both iOS/android?

@pcowgill
Copy link
Member

I was thinking about it, maybe worth forcing the removal to keep the same behavior on both iOS/android?

Yeah, that certainly will make it easier to give advice to testers of the app

@marcelomorgado
Copy link
Contributor Author

Should we keep this open until this feature still under preparation?

@pcowgill
Copy link
Member

Should we keep this open until this feature still under preparation?

Up to you. We can also create a new issue.

@marcelomorgado marcelomorgado changed the title Force account removal after app uninstallation Preparation to force account removal after app uninstallation Apr 23, 2019
@marcelomorgado
Copy link
Contributor Author

Extracted to: #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important and urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants