MyLand refresh/navigation fix

[marcelomorgado]

Issue link

#267

Auto-close the issue?

Closes #267

Types of changes

Bug fix (non-breaking change that fixes an issue)

New feature (non-breaking change that adds functionality)

Notes

Could you tell more about your last comment on the issue?

I think the pattern to follow here is that there's a redux state update for each network request when request is initiated, when it succeeds, and when it fails due to timeout or error.

[pcowgill]

I think the pattern to follow here is that there's a redux state update for each network request when request is initiated, when it succeeds, and when it fails due to timeout or error.

Could you tell more about your last comment on the issue?

Sure! Each type of network request - A) fetching my land; B) fetching land for sale; C) fetching account funding plus approval should have a name for that network request, and then when it it starts we save to redux that network request with name BLA_BLA is now in one of the enum list of options for network request status, between 1) loading, 2) succeeded, 3) failed.

The relevant one here would be the my land request.

Although going too far down this path might not be the best use of time because of the React Suspense discussion here #197

Does that clarify it, or should I go into more detail?

[marcelomorgado]

I think the pattern to follow here is that there's a redux state update for each network request when request is initiated, when it succeeds, and when it fails due to timeout or error.

Could you tell more about your last comment on the issue?

Sure! Each type of network request - A) fetching my land; B) fetching land for sale; C) fetching account funding plus approval should have a name for that network request, and then when it it starts we save to redux that network request with name BLA_BLA is now in one of the enum list of options for network request status, between 1) loading, 2) succeeded, 3) failed.

The relevant one here would be the my land request.

Although going too far down this path might not be the best use of time because of the React Suspense discussion here #197

Does that clarify it, or should I go into more detail?

Oh, I see, something like this?

{ type: 'FETCH_POSTS_REQUEST' }
{ type: 'FETCH_POSTS_FAILURE', error: 'Oops' }
{ type: 'FETCH_POSTS_SUCCESS', response: { ... } }

Extracted from redux doc.

[pcowgill]

Oh, I see, something like this:

{ type: 'FETCH_POSTS_REQUEST' }
{ type: 'FETCH_POSTS_FAILURE', error: 'Oops' }
{ type: 'FETCH_POSTS_SUCCESS', response: { ... } }

Extracted from redux doc.

Yep, exactly

[pcowgill]

@marcelomorgado I know there were a couple issues being tracked in issue #267 . Have some of them since become obsolete? Just checking whether this PR indeed closes all of them.

[marcelomorgado]

@marcelomorgado I know there were a couple issues being tracked in issue #267 . Have some of them since become obsolete? Just checking whether this PR indeed closes all of them.

This PR is addressing:

• Fix: Refreshing from blockchain was removed on-process purchase lands;
• Fix: After redirect user to MyLandScreen the menu link Land For Sale was jumped the user to Buy Screen of already bought land.
• UX improvement: Redirect the user to MyLandScreen after clicking on Buy button (only possible after fixing both bugs above).

[pcowgill]

@marcelomorgado Great work!

[pcowgill]

@marcelomorgado I know there were a couple issues being tracked in issue #267 . Have some of them since become obsolete? Just checking whether this PR indeed closes all of them.

This PR is addressing:

* Fix: Refreshing from blockchain was removed on-process purchase lands;

* Fix: After redirect user to `MyLandScreen` the menu link `Land For Sale` was jumped the user to Buy Screen of already bought land.

* UX improvement: Redirect the user to `MyLandScreen` after clicking on `Buy` button (only possible after fixing both bugs above).

Awesome, this is a big improvement!!

[pcowgill]

@marcelomorgado This is looking great! It's very impressive how quickly you turned these changes around.