Skip to content
This repository has been archived by the owner on Sep 28, 2019. It is now read-only.
This repository has been archived by the owner on Sep 28, 2019. It is now read-only.

Move validateInputURL #8

Open
jonasfj opened this issue Feb 29, 2016 · 0 comments
Open

Move validateInputURL #8

jonasfj opened this issue Feb 29, 2016 · 0 comments

Comments

@jonasfj
Copy link
Contributor

jonasfj commented Feb 29, 2016

It's okay to make functions, not everything has to be a method...
And duplicating configuration like allowedPatterns in an effort to make method is bad.

Pretty sure I gave this feedback before, validateInputURL should be moved.
Probably it belongs inside the API handler. As we should reject illegal URLs immediately.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonasfj