This repository has been archived by the owner on May 9, 2020. It is now read-only.
Bug 1302596: Retry image download when it fails #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmitche
approved these changes
Sep 3, 2019
We already have retries for when the download fails, but not when the downloaded image is corrupted. We add a retry for the general `ensureImage()` function, for edge cases like above. As we are not retrying because of possible network temporary outage, we configure the waiting time to be a small value.
|
The failed test is unrelated and you will be addressed in a follow-up PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have retries for when the download fails, but not when the
downloaded image is corrupted.
We add a retry for the general
ensureImage()function, for edge caseslike above.
As we are not retrying because of possible network temporary outage, we
configure the waiting time to be a small value.