Skip to content
This repository has been archived by the owner on May 9, 2020. It is now read-only.

Bug 1520824: add kvm device #540

Merged
merged 1 commit into from Feb 26, 2020
Merged

Bug 1520824: add kvm device #540

merged 1 commit into from Feb 26, 2020

Conversation

walac
Copy link
Contributor

@walac walac commented Feb 25, 2020

When enabled, it exposes /dev/kvm to the container, allowing to run
emulators with hardware virtualization support.

When enabled, it exposes /dev/kvm to the container, allowing to run
emulators with hardware virtualization support.
@walac walac requested a review from djmitche February 25, 2020 14:17
@walac walac self-assigned this Feb 25, 2020
Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two questions:

  • Do we want to be able to control access to this feature on a per-worker-pool basis? I think we do that for privileged?
  • It looks like this would allow concurrent tasks to both talk to /dev/kvm - is that true, and intended?

@walac
Copy link
Contributor Author

walac commented Feb 26, 2020

Do we want to be able to control access to this feature on a per-worker-pool basis? I think we do that for privileged?

/dev/kvm doesn't have security implications according to my research

It looks like this would allow concurrent tasks to both talk to /dev/kvm - is that true, and intended?

It causes no harm it being shared, afaik. Furthermore, it is implemented for one specific use case.

@walac walac merged commit abc8077 into taskcluster:master Feb 26, 2020
@walac walac deleted the kvm branch March 16, 2020 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants