This repository has been archived by the owner on May 9, 2020. It is now read-only.
Bug 1057882 - Basic Service Support r=garndt #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will update the docs shortly after a r? |
| @@ -0,0 +1,87 @@ | |||
| /** | |||
| This module handles the creation of the "taskcluster" proxy container which | |||
There was a problem hiding this comment.
Is this copied from taskcluster_proxy.js?
Adds support for using command / image / env / alias for services this does not yet address fancier needs such as sub services or logs of services.
lightsofapollo
force-pushed
the
services
branch
from
0991bdc
to
155ecad
Compare
| @@ -22,34 +23,13 @@ var PAYLOAD_SCHEMA = | |||
|
|
|||
| // This string was super long but I wanted to say all these thing so I broke it | |||
| // out into a constant even though most errors are closer to their code... | |||
| var IMAGE_ERROR = 'Pulling docker image "%s" has failed this may indicate an ' + | |||
| var IMAGE_ERROR = 'Pulling docker a image has failed this may indicate an ' + | |||
There was a problem hiding this comment.
This error seems to read oddly (at least to me). Perhaps "Pulling a docker image has failed. This may indicate an error with [...]"
|
Closing pull request because it's greatly outdated now. Can reopen and update if this feature is useful later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using command / image / env / alias for services this does
not yet address fancier needs such as sub services or logs of services.