Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publishing steps to also generate a universal wheel #7

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Update publishing steps to also generate a universal wheel #7

merged 1 commit into from
Aug 21, 2017

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Aug 7, 2017

Fixes #6.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b4a2736 on edmorley:publish-wheels into a2b7379 on taskcluster:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e8b7a57 on edmorley:publish-wheels into a2b7379 on taskcluster:master.

@edmorley
Copy link
Contributor Author

@petemoore, no rush but could you review at some point? :-)

@petemoore
Copy link
Member

@petemoore, no rush but could you review at some point? :-)

Hey @edmorley sorry about that, I was on PTO for the last two weeks! Looking at it now.

Copy link
Member

@petemoore petemoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @edmorley ,

Based on the details you provided in #6 should we also add setuptools and wheel to requirements.txt?

Thanks for the PR! :-)

Pete

@petemoore petemoore merged commit 2b20411 into taskcluster:master Aug 21, 2017
@edmorley edmorley deleted the publish-wheels branch August 22, 2017 10:15
@edmorley
Copy link
Contributor Author

edmorley commented Aug 22, 2017

Based on the details you provided in #6 should we also add setuptools and wheel to requirements.txt?

From IRC for posterity:

emorley: I think that typically adding setuptools/wheel to the app's requirements.txt is considered not best practice, since they are needed before installing the requirements (eg during python/pip bootstrap)
emorley: the pip install script installs both
pmoore: ah cool
pmoore: then i'll land it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants