Bug 1287112 - chain of trust in generic worker #123
Conversation
| @@ -8,7 +8,7 @@ Development Setup | |||
| ----------------- | |||
|
|
|||
| 1. Install: `npm install` | |||
| 2. Run the webserver: `gulp webserver` | |||
| 2. Run the webserver: `./node_modules/.bin/gulp` | |||
There was a problem hiding this comment.
Gulp recommends installing with -g, which would put it in PATH. I guess this is fine though. (node hackers would know what you meant)
There was a problem hiding this comment.
The preference is for it to not be installed globally at all and left local. Then map a start script to gulp:
"scripts": {
"start": "gulp"
}So you start the web server with npm start.
|
I just have the one comment about how to config the worker to find the cert.. |
|
Thanks guys! I'll try to get to this tomorrow. |
|
Ah, blast - I forgot about this PR. Will get back to this shortly... |
|
@petemoore .. shortly? :) |
|
@petemoore can you update this so we can get it merged? :) |
|
So finally I got round to updating this PR! It had totally bit-rotted! @djmitche @eliperelman let me know what you think! |
| } | ||
| ``` | ||
|
|
||
| # Feature: `chainOfTrust` |
There was a problem hiding this comment.
I know it's late, but this should have been h2 or h3.
| `features` object. | ||
|
|
||
| Note: Some features require additional information within the task definition. | ||
| Features may also require scopes. Consult the documentation for each feature |
There was a problem hiding this comment.
Also, double spaces do not render in HTML, so we need to break the habit of double spacing after a full stop. 😆
There was a problem hiding this comment.
Haha, you'll have pry that second space out of my cold, dead fingers :)
Added some docs about the new feature.