This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Add support for x-taskcluster-skip-cache header #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhford
reviewed
Oct 31, 2016
| '', | ||
| '**Caching**, artifacts may be cached in data centers closer to the', | ||
| 'workers in-order to reduce bandwidth costs. This can lead to response', | ||
| 'times at upwards 30 seconds. Caching can be skipped by setting the header', |
There was a problem hiding this comment.
I don't think we should be putting a specific time in this comment. Let's leave it as "This can lead to longer response times when there are problems with resource caching".
jhford
reviewed
Oct 31, 2016
| @@ -356,6 +356,9 @@ var replyWithArtifact = async function(taskId, runId, name, req, res) { | |||
| if (!region) { | |||
| debug('artifact from CDN for ip: %s', req.headers['x-forwarded-for']); | |||
| url = this.publicBucket.createGetUrl(prefix); | |||
| } else if (req.headers['x-taskcluster-skip-cache'] === 'true') { | |||
There was a problem hiding this comment.
should we .toLowerCase() the header value before comparison? Maybe we should also support 1|0?
There was a problem hiding this comment.
We should... good catch..
|
I'm +1 for this. In the case of resources in AWS where this would be used (mainly Treeherder), it's either we incur a transfer by cloud-mirror and then serve from that bucket, or we direct Treeherder to the original bucket still incurring the transfer. That seems acceptable in this case. |
imbstack
pushed a commit
that referenced
this pull request
Dec 14, 2018
Add support for x-taskcluster-skip-cache header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.