All docs show an error #1842
Comments
|
Looking into it |
|
@djmitche Nice to note things is that, if one page breaks, all the other pages breaks too ! |
|
@djmitche I m looking into it .It seem's interesting .Can you please assign me this one ? :) |
|
@naima-shaikh I can, but we do need this fixed soon -- we need to make another release of TC, with this fixed. If you can fix it in, say, the next 24 hours that would be great.. |
|
(if not, that's fine to, just let us know) |
|
@djmitche thanks for assigning it to me . I will try to fix it within 24 hours :) |
|
Please let me know if you are unable yo solve it , I have already debugged
the following, will also send the patch if you can not.
@naima-shaikh
…On Thu, 31 Oct, 2019, 18:44 naima, ***@***.***> wrote:
@djmitche <https://github.com/djmitche> thanks for assigning it to me . I
will try to fix it within 24 hours :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1842?email_source=notifications&email_token=AM6PS4XE2I5PAWPD5IXC3E3QRLK43A5CNFSM4JHDCJFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECXXBNQ#issuecomment-548368566>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6PS4RDMQFXY2RKLEDBDS3QRLK43ANCNFSM4JHDCJFA>
.
|
|
Note that there is already an issue and a pull-request open to fix the error panel positioning. #1660 |
|
Cool but I dont think the error would be anyway related to the following
PR😅
…On Thu, 31 Oct, 2019, 19:09 Hassan Ali, ***@***.***> wrote:
Note that there is already an issue and a pull-request open to fix the
error panel positioning. #1660
<#1660>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1842?email_source=notifications&email_token=AM6PS4QQPHE5WML3A5XU2X3QRLN2HA5CNFSM4JHDCJFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECXZYSA#issuecomment-548379720>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6PS4XRJGTZL5ZKQZXOPI3QRLN2HANCNFSM4JHDCJFA>
.
|
|
@djmitche @vishakhanihore |
|
Did you pull the latest changes from master? |
|
@helfi92 Sorry . i m doing it now :) |
|
@naima-shaikh Any Progress ? |
|
@vishakhanihore I think this issue is already fixed by @djmitche |
|
@djmitche is this fixed?
…On Fri, 1 Nov, 2019, 21:18 naima, ***@***.***> wrote:
@vishakhanihore <https://github.com/vishakhanihore> This issue is already
fixed by @djmitche <https://github.com/djmitche> with a similar logic :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1842?email_source=notifications&email_token=AM6PS4QFGD5SU5HQRLU7GJ3QRRFWVA5CNFSM4JHDCJFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3J7EY#issuecomment-548839315>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6PS4XGYCGLKEOETGB5DH3QRRFWVANCNFSM4JHDCJFA>
.
|
|
Sorry, I fixed a different bug in #1849 and pinged @naima-shaikh. That was my fault. It's not fixed. |
|
@djmitche Alright thanks for informing :) .let me look into it again . |
|
@naima-shaikh , feel free to collaborate with me if you are stuck anywhere.
Two is always better than one😁
…On Fri, 1 Nov, 2019, 22:17 naima, ***@***.***> wrote:
@djmitche <https://github.com/djmitche> Alright thanks for informing :)
.let me look into it again .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1842?email_source=notifications&email_token=AM6PS4T4KR6BTGC3HDLXWOTQRRMRFA5CNFSM4JHDCJFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3PFLQ#issuecomment-548860590>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6PS4W4GONXDUJ7F3UR23DQRRMRFANCNFSM4JHDCJFA>
.
|
|
905228f seems to be the culprit. |
|
@helfi92 rather than reverting to lower version, cant we disable ESlint for
this 4 lines ?
…On Fri, 1 Nov, 2019, 23:16 Hassan Ali, ***@***.***> wrote:
905228f
<905228f>
seems to be the culprit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1842?email_source=notifications&email_token=AM6PS4TTALCO5FEWTD6AYU3QRRTPDA5CNFSM4JHDCJFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3VB4Y#issuecomment-548884723>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6PS4WQXE5EB5QAELSACKLQRRTPDANCNFSM4JHDCJFA>
.
|
|
@vishakhanihore Which 4 lines? |
|
The place where its showing unexpected token error line 6-10?
…On Sat, 2 Nov, 2019, 00:00 Hassan Ali, ***@***.***> wrote:
@vishakhanihore <https://github.com/vishakhanihore> Which 4 lines?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1842?email_source=notifications&email_token=AM6PS4SKBKKO7UYFBL2Q2ADQRRYSVA5CNFSM4JHDCJFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3Y74A#issuecomment-548900848>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6PS4RSAMOSGKC24D6F7BTQRRYSVANCNFSM4JHDCJFA>
.
|
I'm not sure where which line 6-10 that is. I will file an issue soon to have the UI migrated to eslint v6. |
|
I'm super-confused how eslint -- which is a devDependency -- could cause a failure at runtime. |
|
:boggle: |
Describe the bug
API reference pages are showing an error message, and no references.
To Reproduce
Steps to reproduce the behavior:
Unexpected token (6:14)Expected behavior
Screenshots
Additional context
This error appears to be "sticky" -- any other docs pages will also fail to render after seeing this error.
The bug has been introduced since v21.2.0, as that version renders the documentation correctly.
The text was updated successfully, but these errors were encountered: