Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] No cancel button for tasks #1875

Closed
djmitche opened this issue Nov 3, 2019 · 18 comments · Fixed by #1910
Closed

[UI] No cancel button for tasks #1875

djmitche opened this issue Nov 3, 2019 · 18 comments · Fixed by #1910
Assignees
Labels
bug Something isn't working

Comments

@djmitche
Copy link
Collaborator

djmitche commented Nov 3, 2019

Describe the bug
Cancel should be an option alongside "rerun" and "schedule"

To Reproduce

  1. Go to https://community-tc.services.mozilla.com/tasks/KdwFUTxUTiWiHoRDBYhEmA/runs/0
  2. Hover over the thing in the lower right

Expected behavior
A "cancel" option

Screenshots
screenshot

@djmitche djmitche added the bug Something isn't working label Nov 3, 2019
@glandium
Copy link

glandium commented Nov 4, 2019

Retrigger would be nice too.

@aryamanpuri
Copy link
Contributor

@djmitche Can you assign me this issue ?

@helfi92
Copy link
Contributor

helfi92 commented Nov 4, 2019

web-server uses the following logic to fetch actions

const url = await queue.buildUrl(
queue.getLatestArtifact,
taskGroupId,
'public/actions.json',
);

https://community-tc.services.mozilla.com/api/queue/v1/task/QA6K2qySQNaQBb2B806_vg/artifacts/public%2Factions.json returns a 404. @djmitche are we using a bad url or is this file simply non-existent in the community deployment?

@SimonSapin
Copy link
Contributor

SimonSapin commented Nov 4, 2019

Isn’t actions.json for customizable, task-specific actions? Shouldn’t "cancel" be built-in without each task configuring it? Like "rerun" seems to be.

@helfi92
Copy link
Contributor

helfi92 commented Nov 4, 2019

Shouldn’t "cancel" be built-in without each task configuring it? Like "rerun" seems to be.

Agreed.

@helfi92
Copy link
Contributor

helfi92 commented Nov 4, 2019

@aryamanpuri Let me know if you had questions.

@lissyx
Copy link
Contributor

lissyx commented Nov 5, 2019

Retrigger would be nice too.

I filed the same :) #1892

@aryamanpuri
Copy link
Contributor

aryamanpuri commented Nov 5, 2019

@helfi92 Can you help me with the onclick function of the cancel button. The remaining buttons for tasks are " disabled: actionLoading" .
And what is meant by Retrigger ?

@helfi92
Copy link
Contributor

helfi92 commented Nov 5, 2019

@aryamanpuri
Copy link
Contributor

aryamanpuri commented Nov 5, 2019

@helfi92 There is no action on the click of buttons in this link . https://community-tc.services.mozilla.com/tasks/KdwFUTxUTiWiHoRDBYhEmA/runs/0 . So the task performed by them is still active or not ?

@helfi92
Copy link
Contributor

helfi92 commented Nov 5, 2019

I'm not sure I understand the question. Can you elaborate, please?

@aryamanpuri
Copy link
Contributor

On this link https://community-tc.services.mozilla.com/tasks/KdwFUTxUTiWiHoRDBYhEmA/runs/0 , All the icons/buttons are still active or not? That is these icons are static (there is no action on clicking them).

@helfi92
Copy link
Contributor

helfi92 commented Nov 5, 2019

If the buttons are disabled, there should be a tooltip explaining why. If you see "(Auth Required)", it means you need to login first to use these buttons.

@aryamanpuri
Copy link
Contributor

aryamanpuri commented Nov 5, 2019

@helfi92 My bad.

@helfi92
Copy link
Contributor

helfi92 commented Nov 5, 2019

Retrigger would be nice too.

#1893

@helfi92
Copy link
Contributor

helfi92 commented Nov 5, 2019

@aryamanpuri I saw that you opened a pull request then closed it. Let me know when you want me to review a pull-request.

@helfi92
Copy link
Contributor

helfi92 commented Nov 6, 2019

@aryamanpuri How is it going? :-)

@helfi92
Copy link
Contributor

helfi92 commented Nov 6, 2019

@aryamanpuri I guess I can create a pull-request from my earlier comment #1875 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants