Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: GitHub Quickstart is not mobile friendly #1934

Closed
vishakhanihore opened this issue Nov 9, 2019 · 4 comments · Fixed by #1939
Closed

[UI]: GitHub Quickstart is not mobile friendly #1934

vishakhanihore opened this issue Nov 9, 2019 · 4 comments · Fixed by #1939
Labels
bug Something isn't working

Comments

@vishakhanihore
Copy link
Contributor

Describe the bug

Fields and Descriptions in GitHub Quickstart is not responsiveness.

To Reproduce

Steps to reproduce the behaviour:

  1. Go to 'http://127.0.0.1:5080/quickstart'
  2. Choose <iPhone 8 device
  3. See error

Expected behaviour

Make the page responsive for all the mobile device.

Screenshots

Screenshot 2019-11-09 at 5 16 51 PM

See the Label Cutout and Also see the extra space in Description and the Field

@vishakhanihore vishakhanihore added the bug Something isn't working label Nov 9, 2019
@vishakhanihore
Copy link
Contributor Author

@helfi92 @djmitche May I get assigned 😄 ?

@helfi92
Copy link
Contributor

helfi92 commented Nov 9, 2019

This view is being revamped in #1449.

See the Label Cutout

We can probably just rename the placeholders to "Org Name" and "Repo Name". Feel free to send a PR :)

and Also see the extra space in Description and the Field

The description field is a text area component that takes allows multiple lines as input. The space is expected.

@vishakhanihore
Copy link
Contributor Author

vishakhanihore commented Nov 9, 2019 via email

@helfi92
Copy link
Contributor

helfi92 commented Nov 9, 2019

Or we can placeholders inline in mobile view?

There's a third icon (shows up when both input fields are filled) that has a relationship with both inputs. We would need to always have it beside those two inputs.

If we put them inline, then the icon would need on the right centered between the two inputs. Changing the repo placeholder on the other hand makes more sense to me since that doesn't add any code complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants