Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrigger removes too much stuff #1988

Closed
djmitche opened this issue Nov 15, 2019 · 0 comments · Fixed by #1991
Closed

Retrigger removes too much stuff #1988

djmitche opened this issue Nov 15, 2019 · 0 comments · Fixed by #1991
Assignees
@djmitche
Labels
bug Something isn't working

Comments

@djmitche
Copy link
Collaborator

The built-in "retrigger" button strips TASK_ADDED_FIELDS recursively, meaning that if there's a taskId property anywhere in the task definition, it is removed. Those should only be omitted at the top level.
@djmitche djmitche added the bug Something isn't working label Nov 15, 2019
@djmitche djmitche self-assigned this Nov 15, 2019
djmitche added a commit to djmitche/taskcluster that referenced this issue Nov 15, 2019
@djmitche
Don't remove taskId within task defs
5428921 
Fixes taskcluster#1988.
@djmitche djmitche mentioned this issue Nov 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djmitche djmitche

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't remove taskId within task defs djmitche/taskcluster
1 participant
@djmitche