Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1664 ui make homepage mobile friendly #1692

Merged
merged 17 commits into from Oct 22, 2019
Merged

1664 ui make homepage mobile friendly #1692

Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ae0c45d
added media query for smaller font
naima-shk Oct 18, 2019
b7029b5
added media query for smaller font
naima-shk Oct 18, 2019
caa7410
added media query for smaller font
naima-shk Oct 18, 2019
6443d44
added media query for smaller font
naima-shk Oct 18, 2019
565ed6f
added media query for smaller font
naima-shk Oct 18, 2019
947352f
added media query for smaller font
naima-shk Oct 18, 2019
fc3cebf
fixed spacing errors
naima-shk Oct 18, 2019
49eb952
fixed spacing errors
naima-shk Oct 18, 2019
cc16f69
fix linting error
naima-shk Oct 20, 2019
716d2b2
Merge branch 'master' into 1664-ui-make-homepage-mobile-friendly
naima-shk Oct 21, 2019
acb26a2
used material ui breakpoints
naima-shk Oct 21, 2019
39bdfae
resolved conflict
naima-shk Oct 21, 2019
f450b50
update changelog and linting
naima-shk Oct 22, 2019
63f804f
update changelog and linting
naima-shk Oct 22, 2019
faea32d
update changelog and linting
naima-shk Oct 22, 2019
4506a7a
changed classname from text to ciDescription
naima-shk Oct 22, 2019
2b654ab
changed font size from 20 to 16
naima-shk Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion ui/src/components/Homepage/index.jsx
View file
Open in desktop
Expand Up @@ -20,6 +20,9 @@ import SignInDialog from '../SignInDialog';
[theme.breakpoints.down('sm')]: {
marginBottom: theme.spacing.double,
},
'@media (max-width: 400px)': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use material-ui breakpoints instead of hard-coding width values. See line above for an example.

fontSize: '40px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fontSize: 40,

},
},
actions: {
marginTop: theme.spacing.triple,
Expand All @@ -34,6 +37,11 @@ import SignInDialog from '../SignInDialog';
fill: theme.palette.common.white,
marginRight: theme.spacing.unit,
},
text: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename class to ciDescription.

'@media (max-width: 400px)': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comment.

fontSize: '20px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fontSize: 20,

},
},
}))
export default class HomePage extends Component {
state = {
Expand Down Expand Up @@ -64,7 +72,7 @@ export default class HomePage extends Component {
{window.env.APPLICATION_NAME}
</Typography>
</Hidden>
<Typography variant="h5">
<Typography variant="h5" className={classes.text}>
{
"A task execution framework that supports Mozilla's continuous integration and release processes."
}
Expand Down