Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styleguidist version to v9 #1830

Closed
wants to merge 2 commits into from
Closed

Update styleguidist version to v9 #1830

wants to merge 2 commits into from

Conversation

PaliwalArpit
Copy link

No description provided.

@PaliwalArpit PaliwalArpit requested a review from a team as a code owner October 30, 2019 08:54
@PaliwalArpit
Copy link
Author

PaliwalArpit commented Oct 30, 2019

I am not sure why these checks are failing, its just version upgrade that is being done, any idea?
In ideal case yarn.lock should be in gitignore isn't it?

@helfi92
Copy link
Contributor

helfi92 commented Oct 30, 2019

I am not sure why these checks are failing, its just version upgrade that is being done, any idea?
In ideal case yarn.lock should be in gitignore isn't it?

yarn.lock is important to have to ensure consistent installs across machines (https://yarnpkg.com/lang/en/docs/yarn-lock/). yarn add react-styleguidist should update yarn.lock.

The problem all of this is not working is because there has been some breaking changes which will require changing our source code. Did you check for the breaking changes in https://github.com/styleguidist/react-styleguidist/releases since v7? Did you find any breaking changes?

@PaliwalArpit
Copy link
Author

@helfi92 Hey, I can see PR for upgrading to v10, there as well we have check failure for taskcluster-ui. Are we skipping v9 all together?
Still i did some digging here inside logs:

Inside log and in code the error we are encountering is in :
`error: Unable to resolve path to module 'react-styleguidist/lib/rsg-components/StyleGuide/StyleGuideRenderer' (import/no-unresolved) at src/styleguide/StyleGuideRenderer.jsx:2:24:

1 | import React, { Fragment } from 'react';

2 | import StyleGuide from 'react-styleguidist/lib/rsg-components/StyleGuide/StyleGuideRenderer';
| ^
3 | import FontStager from '../components/FontStager';
4 |
5 | const StyleGuideRenderer = props => (`

Found one possible solution for this as : styleguidist/react-styleguidist#1051

@helfi92
Copy link
Contributor

helfi92 commented Oct 31, 2019

@helfi92 Hey, I can see PR for upgrading to v10, there as well we have check failure for taskcluster-ui. Are we skipping v9 all together?

Sure. If it was me, I would probably do the following:

  1. Upgrade v7 to v8 locally and check that the styleguide is working
  2. Upgrade v8 to v9 locally and check that the styleguide is working
  3. Upgrade v9 to v10 locally and check that the styleguide is working
  4. Push my changes

To check that the styleguide is working, I would

  1. Inside the ui directory, I would run
yarn styleguide
  1. Navigate to http://localhost:6060 and make sure it works

@helfi92
Copy link
Contributor

helfi92 commented Oct 31, 2019

Found one possible solution for this as : styleguidist/react-styleguidist#1051

Sure, if that fixes it, then that's good :)

@PaliwalArpit
Copy link
Author

@helfi92 What are your thoughts on v9 style guide? Are we keeping this or version upgrade work well for you to v10?
Please let me know what can be done with this PR, I will close otherwise to avoid cluttering.

@helfi92
Copy link
Contributor

helfi92 commented Nov 15, 2019

Upgrading to v10 works for me.

@helfi92 helfi92 closed this Feb 21, 2020
@helfi92 helfi92 removed the request for review from a team March 4, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants