New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update styleguidist version to v9 #1830
Conversation
I am not sure why these checks are failing, its just version upgrade that is being done, any idea? |
The problem all of this is not working is because there has been some breaking changes which will require changing our source code. Did you check for the breaking changes in https://github.com/styleguidist/react-styleguidist/releases since v7? Did you find any breaking changes? |
@helfi92 Hey, I can see PR for upgrading to v10, there as well we have check failure for taskcluster-ui. Are we skipping v9 all together? Inside log and in code the error we are encountering is in : 1 | import React, { Fragment } from 'react';
Found one possible solution for this as : styleguidist/react-styleguidist#1051 |
Sure. If it was me, I would probably do the following:
To check that the styleguide is working, I would
|
Sure, if that fixes it, then that's good :) |
@helfi92 What are your thoughts on v9 style guide? Are we keeping this or version upgrade work well for you to v10? |
Upgrading to v10 works for me. |
No description provided.