Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1603197 - improve irc service logging #2167

Merged
merged 2 commits into from Dec 12, 2019
Merged

Bug 1603197 - improve irc service logging #2167

merged 2 commits into from Dec 12, 2019

Conversation

djmitche
Copy link
Collaborator

Bugzilla Bug: 1603197

@djmitche
Bug 1603197 - add some notice-level logging to notify's irc service
34bd807 
This should provide a little context as to what the process is doing,
rather than total log-silence.
@djmitche
Bug 1603197 - improve irc server error handling
fd4184e
@djmitche djmitche requested a review from a team as a code owner December 12, 2019 03:22
imbstack
imbstack approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@imbstack imbstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear we did this before at some point. Might be worth spelunking the history of this file to see what we've changed and why over time. Won't hurt to land this though I expect.

djmitche
djmitche commented Dec 12, 2019
View reviewed changes
Copy link
Collaborator Author

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some poking around while investigating the issue, and didn't find anything that stood out. Since it's your recollection, do you want to put on a hard-hat for a few minutes?

@djmitche djmitche merged commit ebc3f43 into taskcluster:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbstack imbstack imbstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djmitche @imbstack