Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anonymous scope in web-server #3616

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Add anonymous scope in web-server #3616

merged 2 commits into from
Oct 5, 2020

Conversation

helfi92
Copy link
Contributor

@helfi92 helfi92 commented Oct 5, 2020

Github Bug/Issue: Fixes #3591

@helfi92 helfi92 requested a review from a team as a code owner October 5, 2020 16:09
@helfi92 helfi92 self-assigned this Oct 5, 2020
@helfi92 helfi92 requested review from djmitche and petemoore and removed request for a team October 5, 2020 16:09
petemoore
petemoore approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@petemoore petemoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me Hassan, but I'll defer to dustin for a more thorough review, as I'm not confident I know the web server well enough to know if this captures everything. Thanks!

djmitche
djmitche approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! These scopes will then be displayed in "Profile" and can be used to create clients.

@helfi92 helfi92 merged commit 0337645 into taskcluster:main Oct 5, 2020
@helfi92 helfi92 deleted the web-server-anonymous-scopes branch October 5, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmitche djmitche djmitche approved these changes

@petemoore petemoore petemoore approved these changes

Assignees

@helfi92 helfi92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add assume:anonymous to the scopes returned by User::scopes in web-server
3 participants
@helfi92 @djmitche @petemoore