feat(worker-manager): Immediate worker provisioning for Azure #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotas
requested review from
petemoore and
matt-boris
and removed request for
a team
lotas
commented
Apr 26, 2022
| @@ -50,6 +50,35 @@ helper.secrets.mockSuite(testing.suiteName(), [], function(mock, skipping) { | |||
| monitor = await helper.load('monitor'); | |||
| }); | |||
|
|
|||
| const assertProvisioningState = async (expectations) => { | |||
There was a problem hiding this comment.
this is moved out of one suit, because it is needed in two different
lotas
commented
Apr 26, 2022
|
|
||
| test('successful provisioning of VM without public ip', async function() { | ||
| await assertProvisioningState({ ip: 'none', nic: 'none', vm: 'none' }); | ||
| suite('provisionResources without public IP', function() { |
There was a problem hiding this comment.
extracted this test in separate case, as its success depends on initial setup(), worker pool needs to have proper workerConfig to set skipPublicIP properly
lotas
force-pushed
the
feature/scanner-stats
branch
from
02e14b0
to
338f8a7
Compare
lotas
commented
Apr 26, 2022
| setup('create un-provisioned worker', async function() { | ||
| const workerPool = await makeWorkerPool(); | ||
| const workerInfo = { | ||
| existingCapacity: 0, | ||
| requestedCapacity: 0, | ||
| }; | ||
|
|
||
| // prevent the worker from being immediately provisioned | ||
| sandbox.stub(provider, 'checkWorker').returns('ok'); |
There was a problem hiding this comment.
this just ensures that internal state for fake calls are not interfered by calling checkWorker inside provision() call
lotas
force-pushed
the
feature/scanner-stats
branch
from
338f8a7
to
8e5dd17
Compare
matt-boris
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improve worker manager Azure provisioning.
Till now, Azure was the only provider that was not actually doing any cloud api calls in the
provisionerloop, and only created worker record inREQUESTEDstate, that was later picked byworkerScannerAzure.This sometimes can take 10-20 minutes, and, considering overall provisioning slowness, it often ends with worker being terminated, as they fail to start within given time (
terminateAfter) (Leading to errors seen in #4999)Related to #4999