Add support for ingress nginx and certbot to ingress.yml #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotas
requested review from
petemoore and
matt-boris
and removed request for
a team
lotas
force-pushed
the
feat/4913-ingress-nginx-support
branch
from
1965883
to
d273e88
Compare
lotas
commented
Aug 10, 2022
| @@ -87,6 +87,7 @@ script/dev:db:downgrade) shift; exec yarn run dev:db:downgrade "${@}";; | |||
| script/dev:apply) shift; exec yarn run dev:apply "${@}";; | |||
| script/dev:delete) shift; exec yarn run dev:delete "${@}";; | |||
| script/dev:verify) shift; exec yarn run dev:verify "${@}";; | |||
| script/dev:templates) shift; exec yarn run dev:templates "${@}";; | |||
There was a problem hiding this comment.
this is to dump k8s templates with substituted variables into a file for debug purposes
lotas
commented
Aug 10, 2022
| @@ -111,14 +115,23 @@ const actions = [ | |||
| provides: ['target-verify'], | |||
| run: async (requirements, utils) => ({ | |||
| 'target-verify': await execCommand({ | |||
| command: ['kubectl', 'apply', '--dry-run', '-f', '-'], | |||
| command: ['kubectl', 'apply', '--dry-run=client', '-f', '-'], | |||
There was a problem hiding this comment.
this is the preferred way now, old was deprecated
lotas
commented
Aug 10, 2022
| @@ -6,14 +6,24 @@ metadata: | |||
| annotations: | |||
| 'kubernetes.io/ingress.global-static-ip-name': '{{ .Values.ingressStaticIpName }}' | |||
| 'ingress.gcp.kubernetes.io/pre-shared-cert': '{{ .Values.ingressCertName }}' | |||
| 'cert-manager.io/cluster-issuer': '{{ .Values.certManagerClusterIssuerName | default "" }}' | |||
There was a problem hiding this comment.
those extra annotations will do no harm when left blank to any existing deployment.
Plus mozilla is overriding those for moz-specific deployments
This was referenced Aug 10, 2022
Eijebong
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces few changes:
ingress.ymlcan be configured throughdev-config.ymloptioningressType: nginxto generate proper routes (/instead of/*)ingress.ymlcan include cert-manager annotations to provision certificates automaticallydev-deployment.ymlto include information on how to use those optionsFixes #4913