Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6245: generic-worker: support mounting indexed content #6246

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

petemoore
Copy link
Member

Github Bug/Issue: Fixes #6245

@petemoore petemoore self-assigned this May 19, 2023
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to cancel previously created task groups with following scopes:

assume:repo:github.com/taskcluster/taskcluster:*, queue:seal-task-group:taskcluster-github/*, queue:cancel-task-group:taskcluster-github/*

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

queue:seal-task-group:taskcluster-level-1/W_1CjCtOTWS1PcnB32PHlA

This request requires the client to satisfy the following scope expression:

queue:seal-task-group:taskcluster-level-1/W_1CjCtOTWS1PcnB32PHlA

  • method: sealTaskGroup
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-05-19T12:17:43.099Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to cancel previously created task groups with following scopes:

assume:repo:github.com/taskcluster/taskcluster:*, queue:seal-task-group:taskcluster-github/*, queue:cancel-task-group:taskcluster-github/*

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

queue:seal-task-group:taskcluster-level-1/W_1CjCtOTWS1PcnB32PHlA

This request requires the client to satisfy the following scope expression:

queue:seal-task-group:taskcluster-level-1/W_1CjCtOTWS1PcnB32PHlA

  • method: sealTaskGroup
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-05-19T12:55:17.393Z

@petemoore petemoore marked this pull request as ready for review May 19, 2023 14:01
@petemoore petemoore requested a review from a team as a code owner May 19, 2023 14:01
@petemoore petemoore requested review from lotas and matt-boris and removed request for a team May 19, 2023 14:01
Copy link
Contributor

@matt-boris matt-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice! Left a few comments/suggestions :)

workers/generic-worker/schemas/multiuser_posix.yml Outdated Show resolved Hide resolved
workers/generic-worker/schemas/multiuser_windows.yml Outdated Show resolved Hide resolved
workers/generic-worker/schemas/simple_posix.yml Outdated Show resolved Hide resolved
workers/generic-worker/mounts.go Outdated Show resolved Hide resolved
workers/generic-worker/mounts.go Outdated Show resolved Hide resolved
workers/generic-worker/schemas/multiuser_posix.yml Outdated Show resolved Hide resolved
@petemoore
Copy link
Member Author

I'll see if I can add some tests on Monday, so will leave this open. Thanks for the review so far!

@petemoore
Copy link
Member Author

@matt-boris By the way, just a heads up that the biggest code change is to workers/generic-worker/mounts.go - but github is collapsing (hiding) those changes in the "Files changed" tab.

matt-boris
matt-boris previously approved these changes May 22, 2023
Copy link
Contributor

@matt-boris matt-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks Pete

level: minor
reference: issue 6245
---
Generic Worker payload now supports declaratively mounting indexed artifacts into the task directory. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth adding that workers would need an extra scope to be able to "talk to index artifacts"?

Copy link
Contributor

@lotas lotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generic-worker: support mounting indexed artifacts via index namespace + artifact name
3 participants