-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6245: generic-worker: support mounting indexed content #6246
Conversation
Uh oh! Looks like an error! DetailsTaskcluster-GitHub attempted to cancel previously created task groups with following scopes:
Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
Uh oh! Looks like an error! DetailsTaskcluster-GitHub attempted to cancel previously created task groups with following scopes:
Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:
This request requires the client to satisfy the following scope expression:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice! Left a few comments/suggestions :)
I'll see if I can add some tests on Monday, so will leave this open. Thanks for the review so far! |
@matt-boris By the way, just a heads up that the biggest code change is to workers/generic-worker/mounts.go - but github is collapsing (hiding) those changes in the "Files changed" tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks Pete
level: minor | ||
reference: issue 6245 | ||
--- | ||
Generic Worker payload now supports declaratively mounting indexed artifacts into the task directory. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth adding that workers would need an extra scope to be able to "talk to index artifacts"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Github Bug/Issue: Fixes #6245