feat: introduce new API for batch task requests #6915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alphare
requested review from
lotas,
petemoore and
matt-boris
and removed request for
a team
|
I'm submitting this to get some feedback to make sure I'm headed in the right direction. I have a couple of questions inside (in XXX) about auth and validation, I'd be glad to get some pointers there. :) |
Alphare
force-pushed
the
index.batched-taskid
branch
from
cd4f45b
to
8cc3ed2
Compare
lotas
reviewed
Mar 19, 2024
lotas
reviewed
Mar 19, 2024
Alphare
force-pushed
the
index.batched-taskid
branch
from
8cc3ed2
to
72c8b5f
Compare
Alphare
commented
Mar 19, 2024
Alphare
force-pushed
the
index.batched-taskid
branch
from
72c8b5f
to
77f4228
Compare
Merged
lotas
reviewed
Mar 21, 2024
| assert.equal(rows.length, expectedIndexes.length); | ||
| assert.deepStrictEqual(rows, expectedTasks); | ||
|
|
||
| // Order of the input doesn't matter |
lotas
approved these changes
Mar 21, 2024
This is done according to RFC 189¹. In few words, the motivation is to drastically reduce the number of index API calls done by decision tasks, since they sometimes need the task ids for hundreds of tasks. [1] taskcluster/taskcluster-rfcs#189
lotas
force-pushed
the
index.batched-taskid
branch
from
77f4228
to
b59457e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done according to RFC 189¹. In few words, the motivation is to drastically reduce the number of index API calls done by decision tasks, since they sometimes need the task ids for hundreds of tasks.
[1] taskcluster/taskcluster-rfcs#189