Add Bindings view in Hooks create page #730
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| import { hot } from 'react-hot-loader'; | ||
| import React, { Component, Fragment } from 'react'; | ||
| import { withApollo } from 'react-apollo'; | ||
| import classNames from 'classnames'; | ||
| import { withStyles } from '@material-ui/core/styles'; | ||
| import { arrayOf, func, object, string } from 'prop-types'; | ||
| import List from '@material-ui/core/List'; | ||
| import ListItem from '@material-ui/core/ListItem'; | ||
| import ListItemText from '@material-ui/core/ListItemText'; | ||
| import ListSubheader from '@material-ui/core/ListSubheader'; | ||
| import Tooltip from '@material-ui/core/Tooltip'; | ||
| import TextField from '@material-ui/core/TextField'; | ||
| import Typography from '@material-ui/core/Typography'; | ||
| import IconButton from '@material-ui/core/IconButton'; | ||
| import PlusIcon from 'mdi-react/PlusIcon'; | ||
| import DeleteIcon from 'mdi-react/DeleteIcon'; | ||
|
|
||
| @hot(module) | ||
| @withApollo | ||
| @withStyles(theme => ({ | ||
| iconButton: { | ||
| '& svg': { | ||
| fill: theme.palette.text.primary, | ||
| }, | ||
| }, | ||
| plusIcon: { | ||
| marginTop: 80, | ||
| }, | ||
| deleteIcon: { | ||
| marginRight: -15, | ||
| [theme.breakpoints.down('sm')]: { | ||
| marginRight: -14, | ||
| }, | ||
|
There was a problem hiding this comment. I think we can remove L31-33. |
||
| }, | ||
| inputWrapper: { | ||
| display: 'flex', | ||
| justifyContent: 'space-between', | ||
| alignItems: 'center', | ||
| }, | ||
| inputList: { | ||
| flex: 1, | ||
| }, | ||
| bindingListItem: { | ||
| paddingTop: 0, | ||
| paddingBottom: 0, | ||
| }, | ||
| subheader: { | ||
| fontSize: theme.typography.pxToRem(16), | ||
| }, | ||
| })) | ||
| export default class PulseBindings extends Component { | ||
| static propTypes = { | ||
| pulseExchange: string.isRequired, | ||
| pattern: string.isRequired, | ||
| bindings: arrayOf(object).isRequired, | ||
| onBindingAdd: func.isRequired, | ||
| onBindingRemove: func.isRequired, | ||
| onChange: func.isRequired, | ||
| }; | ||
|
|
||
| render() { | ||
| const { | ||
| pulseExchange, | ||
| pattern, | ||
| bindings, | ||
| classes, | ||
| onBindingAdd, | ||
| onBindingRemove, | ||
| onChange, | ||
| } = this.props; | ||
|
There was a problem hiding this comment. Let's add There was a problem hiding this comment. I feel all the props are required for this. Also, I am not sure if we would not need Let me know if there is anything missing |
||
|
|
||
| return ( | ||
| <Fragment> | ||
| <div className={classes.inputWrapper}> | ||
| <List | ||
| className={classes.inputList} | ||
| subheader={ | ||
| <ListSubheader className={classes.subheader}> | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. This was related to the above comment. |
||
| Bindings | ||
| </ListSubheader> | ||
| }> | ||
|
There was a problem hiding this comment. "Bindings" and "Schedule" don't seem to have the same styling. "Bindings" seems to be smaller. Maybe we can avoid putting the title inside the component and just have it defined in the hook form view.
There was a problem hiding this comment. Actually issue was with adding the bidings inside, I have added subheader style in the component and now it looks fine.
|
||
| <ListItem> | ||
| <ListItemText | ||
| primary={ | ||
| <TextField | ||
| required | ||
| label="Pulse Exchange" | ||
| name="pulseExchange" | ||
| placeholder="exchange/<username>/some-exchange-name" | ||
| onChange={onChange} | ||
| fullWidth | ||
| value={pulseExchange} | ||
| /> | ||
| } | ||
| /> | ||
| </ListItem> | ||
| <ListItem> | ||
| <ListItemText | ||
| primary={ | ||
| <TextField | ||
| required | ||
| label="Routing Key Pattern" | ||
| placeholder="#.some-interesting-key.#" | ||
| name="pattern" | ||
| onChange={onChange} | ||
| fullWidth | ||
| value={pattern} | ||
| /> | ||
| } | ||
| /> | ||
| </ListItem> | ||
| </List> | ||
| <Tooltip title="Add Binding"> | ||
| <IconButton | ||
| className={classNames(classes.iconButton, classes.plusIcon)} | ||
| onClick={onBindingAdd}> | ||
| <PlusIcon /> | ||
| </IconButton> | ||
| </Tooltip> | ||
| </div> | ||
| <List> | ||
| {bindings.map(binding => ( | ||
| <ListItem | ||
| className={classes.bindingListItem} | ||
| key={`${binding.exchange}-${binding.routingKeyPattern}`}> | ||
| <ListItemText | ||
| disableTypography | ||
| primary={ | ||
| <Typography variant="body2"> | ||
| <code>{binding.exchange}</code> with{' '} | ||
| <code>{binding.pattern}</code> | ||
| </Typography> | ||
| } | ||
| /> | ||
| <Tooltip title="Delete Binding"> | ||
| <IconButton | ||
| className={classNames(classes.iconButton, classes.deleteIcon)} | ||
| name={binding} | ||
| onClick={() => onBindingRemove(binding)}> | ||
| <DeleteIcon /> | ||
| </IconButton> | ||
| </Tooltip> | ||
| </ListItem> | ||
| ))} | ||
| </List> | ||
| </Fragment> | ||
| ); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marginRight: -theme.spacing.double,