[UI] Make setTimeout work with large timeout values #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wryonik
pushed a commit
to wryonik/taskcluster
that referenced
this pull request
Jun 19, 2019
helfi92
pushed a commit
that referenced
this pull request
Jul 11, 2019
* Add utility to generate/verify taskcluster tokens * Add tests to jwt utlity * Add config keys for jwt * Rename verifyJwt to verifyJwtAuth0 * Adjust CLIENT_ID_PATTERN * Modify strategies to use Taskcluster token * Update Node.js to v10.16.0 * yarn generate * Add requested changes * Lint * Correct comment description of endpoint * Make setTimeout work with large timeout values (#838) * Rename accessToken to taskclusterToken * Upgrade js-yaml * Hotfix: web-server check for user * [UI] Add isSecretDirty logic (#833) * added isSecretDirty logic * Update index.jsx * resolved issue * minor issues resolved * Fix pagination issue in DataTable (#848) * Auth and Role forms UX (#844) * client form done * role form done * minor issues resolved * snackbar confirmation for client complete * snackbar confirmation for role form complete * Return early for new form before showing snackbar * added dialog action for roles form * minor issues resolved * minor issues resolved * removed handleDialogActionError from viewRole * Add missing pieces * Remove focusOnSecondary - it's now set by default * Remove dialogError for when the role form is new A new role won't have the delete dialog option so there's no need to pass dialogError to the component * Rename handleActionDialogError for consistency * Rename handleActionDialogClose for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delay (in milliseconds) for
setTimeoutis a 32 bit signed quantity, which limits it to 2^31-1 ms (2147483647 ms) or 24.855 days. Renewal timers are sometimes 1000 years so we should make sure we don't go past the max value.