Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim .git from project in taskgraph.parameters._get_defaults #109

Merged
merged 1 commit into from Sep 9, 2022

Conversation

gabrielBusta
Copy link
Member

The untrimmed project name from this function is breaking taskgraph test-action-callback

@gabrielBusta gabrielBusta added the bug Something isn't working label Sep 8, 2022
@gabrielBusta gabrielBusta requested review from ahal and a team September 8, 2022 22:12
@gabrielBusta gabrielBusta self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 64.44% // Head: 64.45% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (642e750) compared to base (9536618).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   64.44%   64.45%   +0.01%     
==========================================
  Files          62       62              
  Lines        4896     4898       +2     
==========================================
+ Hits         3155     3157       +2     
  Misses       1741     1741              
Impacted Files Coverage Δ
src/taskgraph/parameters.py 86.79% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we're planning to use mozilla-repo-urls here, so requsting changes for that.

@gabrielBusta gabrielBusta merged commit 088ff1a into main Sep 9, 2022
@gabrielBusta gabrielBusta deleted the trim-dot-git branch September 9, 2022 18:56
@JohanLorenzo
Copy link
Contributor

🚀 \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants