fix: pass in base + head revisions when computing files_changed #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
approved these changes
Apr 24, 2024
| @@ -185,7 +185,9 @@ def get_decision_parameters(graph_config, options): | |||
|
|
|||
| # Define default filter list, as most configurations shouldn't need | |||
| # custom filters. | |||
| parameters["files_changed"] = repo.get_changed_files("AM") | |||
| parameters["files_changed"] = repo.get_changed_files( | |||
There was a problem hiding this comment.
To be clear: we need rev/base_rev because otherwise we default to the previous revision? (And something else for hg...)
There was a problem hiding this comment.
Yes, also this is what the files_changed.py module was doing before my refactor.. I just totally missed the difference
There was a problem hiding this comment.
Oh and technically we were in the top half of that conditional, so we were detecting the base_rev automatically. The detection works great for pushes, but not for pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.