Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep comments in sparsebak.ini when using delete/add commands #29

Closed
ghost opened this issue Apr 10, 2019 · 4 comments
Closed

keep comments in sparsebak.ini when using delete/add commands #29

ghost opened this issue Apr 10, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 10, 2019

If feasible/easy to implement, it'd be nice to keep comments in sparsebak.ini when the file is rewritten (eg. after using add/delete commands).
If it isn't, maybe add a static top comment that user comments will be deleted when the file gets rewritten ?

And/or create a backup .ini file ?

@tasket
Copy link
Owner

tasket commented Apr 10, 2019

This file I have less flexibility with (its managed by Python configparser), but I'll definitely look into it.

@ghost
Copy link
Author

ghost commented Apr 11, 2019

This file I have less flexibility with (its managed by Python configparser)

Yes I saw that when looking at code so I expected that keeping comments/user formatting might not be straightforward.

I'm sure the config format will evolve when/if you add support for multiple volume groups and other stuff so it's not worth loosing time on this minor issue...

tasket added a commit that referenced this issue May 17, 2021
issue #29 and issue #30

Also improve tag list output
@tasket
Copy link
Owner

tasket commented May 17, 2021

@taradiddles A comment/description can now be added to a volume. Its not the same as actual comment lines in the ini, but may serve a similar purpose.

Interestingly, the Python ini parser documentation says that comments beginning with '#' or ';' are supported by default.

@tasket
Copy link
Owner

tasket commented Jun 3, 2021

Closing as this appears to be covered by current beta.

@tasket tasket closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant