feat: golang client POC #3
Conversation
|
Is this a Go package that can be imported externally, or is it just an internal client example? If it can be imported externally, the module path has been set as a vanity URL. If a vanity URL redirector like Gooogle Cloud Platform's Go Vanity URLs server hasn't been set up, |
|
This Go package is supposed to be imported externally. What changes are needed to make this happen? |
|
As I mentioned, Google Cloud Platform has a simple server implementation for this purpose that can be used. It can be proxied under the domain taskforce.sh, but instead of proxying, it can be served as a subdomain with a basic instance, like "go.taskforce.sh/bullmq_proxy_client". |
|
Things you probably need to change if you're going to use a subdomain: modify the module path in |
|
What about using github.com as domain? is it possible? |
It just needs to be changed to "github.com/taskforcesh/bullmq-proxy/clients/golang" as the module path. |
|
What about the path? as the module is inside clients/golang subdirectory? |
| @@ -0,0 +1,5 @@ | |||
| module taskforce.sh/bullmq_proxy_client | |||
There was a problem hiding this comment.
If it is going to be served with GitHub, this should be changed to "github.com/taskforcesh/bullmq-proxy/clients/golang" here, and similarly, all imports should be changed accordingly.
There was a problem hiding this comment.
I see. It would be nicer not to need to append the path to the module as this is a monorepo with packages for several platforms, I guess that would require a different solution, like serving it from a different host right?
There was a problem hiding this comment.
You can also serve the package directly from another repo host (maybe github.com/taskforcesh/proxy-go)
There was a problem hiding this comment.
In monorepo it is required to specify the package path
There was a problem hiding this comment.
Yeah, I prefer the mono repo approach as it will be easier to keep the go library and the proxy in sync.
There was a problem hiding this comment.
I added what you need directly in the first comment
There was a problem hiding this comment.
I understand. I rather not put the extra burden of maintaining an extra host, even if it is a lambda... these things breaks sometimes and could affect users when they need it the most. So I guess I will take the github route for now.
There was a problem hiding this comment.
Thanks for all the feedback :)
There was a problem hiding this comment.
You're welcome, I will contribute for more clients soon!
No description provided.