When adding repeatable job, not all redis-connection.ts error event listeners are removed

[pauliusg]

This is happening for me with shared Redis client. My code:

const queue = new Queue('scheduler, { connection: sharedRedisClient });

await queue.add(data.taskName, data, {
	jobId: data.id.toString(),
	repeat: { cron: taskSchedule.cronRule },
});


for (const listener of sharedRedisClient.listeners('error')) {
	console.log({ listenerBeforeClose: listener.toString() });
}

await queue.close();

for (const listener of sharedRedisClient.listeners('error')) {
	console.log({ listenerAfterClose: listener.toString() });
}

And it still returns listener after close. This an issue for me because this code is executed from API many times and eventually I get MaxListenersExceededWarning.

Temporary I added this code below queue close to resolve my issue:

await queue.close();

const repeat = await schedulerQueue.repeat; // Added code
await repeat.close(); //Added code

Then all listeners are removed.

Looks like there should be a close method added in https://github.com/taskforcesh/bullmq/blob/e17b3f21606757a16630988a69c9607e8c843bd2/src/classes/queue.ts

close(): Promise<void> {
  if (!this.closing) {
    this.closing = async () => {
      if (this._repeat) {
        const repeat = this._repeat();
        await repeat.close();
      }
      await super.close(); // Call close in queue-base.ts
    };
  }
  return this.closing;
}