Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(queue): close repeat connection when calling close #1154

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

roggervalf
Copy link
Collaborator

fixes #1151

@roggervalf roggervalf requested a review from manast March 24, 2022 01:33
@@ -3,8 +3,7 @@ import { JobsOptions, RepeatOptions } from '../interfaces';
import { QueueBase } from './queue-base';
import { Job } from './job';
import { Scripts } from './scripts';
import { CronDate, parseExpression } from 'cron-parser';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were some unused variables here

Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@roggervalf roggervalf merged commit 7d79616 into master Mar 24, 2022
@roggervalf roggervalf deleted the fix-close-repeat branch March 24, 2022 02:39
github-actions bot pushed a commit that referenced this pull request Mar 24, 2022
## [1.78.1](v1.78.0...v1.78.1) (2022-03-24)

### Bug Fixes

* **queue:** close repeat connection when calling close ([#1154](#1154)) ([7d79616](7d79616))
@github-actions
Copy link

🎉 This PR is included in version 1.78.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

namoscato added a commit to namoscato/bullmq that referenced this pull request Mar 30, 2022
…-connection

* 'master' of github.com:taskforcesh/bullmq: (46 commits)
  GitBook: [taskforcesh#106] No subject
  docs(metrics): fix typo
  GitBook: [taskforcesh#105] No subject
  chore(release): 1.78.1 [skip ci]
  fix(queue): close repeat connection when calling close (taskforcesh#1154)
  chore(release): 1.78.0 [skip ci]
  feat(cron-parser): upgrades version to 4.2.1 (taskforcesh#1149) fixes taskforcesh#1147
  test(events): fix flaky test
  chore(release): 1.77.3 [skip ci]
  fix(async-send): check proc.send type (taskforcesh#1150)
  test(rate-limiter): fix flaky test
  chore(release): 1.77.2 [skip ci]
  perf(clean): speed up clean operation using deletion marker (taskforcesh#1144)
  fix(trim-events): consider maxLenEvents as 0 (taskforcesh#1137)
  chore(release): 1.77.1 [skip ci]
  fix(flow): remove processed children (taskforcesh#1060) fixes taskforcesh#1056
  chore(release): 1.77.0 [skip ci]
  feat: allow QueueScheduler to be extended
  chore(release): 1.76.6 [skip ci]
  fix(master): do not export master file (taskforcesh#1136) fixes taskforcesh#1125 ref taskforcesh#1129
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When adding repeatable job, not all redis-connection.ts error event listeners are removed
2 participants