Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge removal of job with removeRepeatable #1235

Closed
kraten opened this issue May 9, 2022 · 2 comments
Closed

Acknowledge removal of job with removeRepeatable #1235

kraten opened this issue May 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@kraten
Copy link

kraten commented May 9, 2022

I found two issues while using the queue removeRepeatable method:

  1. It should throw some error when repeatable job doesn't exist with the provided arguments. Instead it just returns a promise that resolves to null value.
  2. Even when the repeatable job options are correct and job is removed, the promise gets resolved to null. It would be better to have some return value to know that the job got removed.

To summarize, I couldn't find a way to distinguish if the repeatable job is actually removed or the options are incorrect, as they both resolve to null value.

@roggervalf roggervalf added the enhancement New feature or request label May 10, 2022
@roggervalf
Copy link
Collaborator

hi @kraten, this is related to this issue #1211, for now we are only emiting the removed event, I marked this one as an enhancement

github-actions bot pushed a commit that referenced this issue May 11, 2022
# [1.82.0](v1.81.4...v1.82.0) (2022-05-11)

### Features

* **remove-repeatable:** return boolean depending on job existence ([#1239](#1239)) ref [#1235](#1235) ([59b0da7](59b0da7))
@manast
Copy link
Contributor

manast commented May 12, 2022

Fixed here #1239

@manast manast closed this as completed May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants