Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better job.getState #143

Closed
ccollie opened this issue Feb 17, 2020 · 3 comments
Closed

A better job.getState #143

ccollie opened this issue Feb 17, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ccollie
Copy link
Contributor

ccollie commented Feb 17, 2020

For another project, I've written lua code for a more performant job.getState (makes a single roundtrip rather than the multiple in the current codebase). I'd contribute a PR for bull but I noticed that the tests are commented out

https://github.com/taskforcesh/bullmq/blob/master/src/test/test_job.ts#L347

Any plans to revisit this ?

@manast
Copy link
Contributor

manast commented Feb 26, 2020

not sure if the tests are out-commented because the code is ugly or they do not work. You are welcome to contribute with a better getState, it would be very much appreciated.

@manast manast added the enhancement New feature or request label Feb 26, 2020
@roggervalf
Copy link
Collaborator

roggervalf commented Apr 20, 2021

@ccollie the pr was merged, are we safe to close this issue? @manast

@ccollie
Copy link
Contributor Author

ccollie commented Apr 20, 2021

@ccollie the pr was merged, are we safe to close this issue?

Sure, go ahead

@manast manast closed this as completed May 17, 2021
manast added a commit that referenced this issue Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants