fix(python): stop processes when force stop #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Apr 20, 2023
python/bullmq/worker.py
Outdated
|
|
||
| self.closing = True | ||
|
|
||
| await self.blockingRedisConnection.close() | ||
| await self.redisConnection.close() | ||
|
|
||
| def cancelProcessing(self): | ||
| print('hola') |
There was a problem hiding this comment.
Seems to be some debug code left here.
manast
reviewed
Apr 20, 2023
python/bullmq/worker.py
Outdated
| print('hola') | ||
| for job in self.processing: | ||
| print('1u') | ||
| hola = job.cancel() |
There was a problem hiding this comment.
What is the effect of job.cancel()?
There was a problem hiding this comment.
it will stop the execution of that job as in https://www.pythontutorial.net/python-concurrency/python-cancel-tasks/
manast
approved these changes
Apr 21, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 5, 2023
## [3.12.1](v3.12.0...v3.12.1) (2023-05-05) ### Bug Fixes * **python:** stop processes when force stop ([#1837](#1837)) ([514699c](514699c)) * **worker:** close open handles after closing ([#1861](#1861)) fixes [#1312](#1312) ([39286e8](39286e8)) ### Features * **python:** accept redis options as string ([01f549e](01f549e)) * **python:** add moveToDelayed job method ([#1849](#1849)) ([5bebf8d](5bebf8d)) * **python:** add retry method into job ([#1877](#1877)) ([870da45](870da45)) * **python:** add updateData method ([#1871](#1871)) ([800b8c4](800b8c4)) * **python:** add updateProgress method in job class([#1830](#1830)) ([e1e1aa2](e1e1aa2)) * **python:** save stacktrace when job fails ([#1859](#1859)) ([0b538ce](0b538ce)) * **python:** support retryJob logic ([#1869](#1869)) ([b044a03](b044a03))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.