Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable jobs do not check for existence #263

Closed
pc-jedi opened this issue Aug 27, 2020 · 3 comments
Closed

Repeatable jobs do not check for existence #263

pc-jedi opened this issue Aug 27, 2020 · 3 comments

Comments

@pc-jedi
Copy link

pc-jedi commented Aug 27, 2020

In the docs it says:

Bull is smart enough not to add the same repeatable job if the repeat options are the same.

But there is even a test that this should work:
https://github.com/taskforcesh/bullmq/blob/master/src/test/test_repeat.ts#L373-L386

I guess the issue is that skipCheckExists is hardcoded to true

I see two ways to fix this:

  1. Remove the sentence from the docs.
  2. Expose the skipCheckExists via JobsOptions and do not hardcoded it to true.
@pc-jedi
Copy link
Author

pc-jedi commented Dec 21, 2020

Ping @manast

@manast
Copy link
Contributor

manast commented Dec 21, 2020

The documentation is correct. The test is not testing what you highlighted, it is testing, maybe clumsily so, what the documentation says.

@roggervalf
Copy link
Collaborator

#769 tries to add more context on repeatable configs, please @pc-jedi when you get a chance, take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants