fix: avoid calling delay() if queue is being closed #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
reviewed
Jun 25, 2022
src/classes/worker.ts
Outdated
| @@ -468,7 +469,9 @@ export class Worker< | |||
| if (isNotConnectionError(<Error>error)) { | |||
| this.emit('error', <Error>error); | |||
| } | |||
| await this.delay(); | |||
| if (!this.beingClosed) { | |||
There was a problem hiding this comment.
hi @snawaz, did you try to use !this.closing instead of this new attribute?
There was a problem hiding this comment.
@roggervalf : ah, that makes sense. I just removed the new variable and used this.closing itself.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2022
## [1.86.3](v1.86.2...v1.86.3) (2022-06-26) ### Bug Fixes * avoid calling delay() if queue is being closed ([#1295](#1295)) ([52a5045](52a5045))
|
🎉 This PR is included in version 1.86.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One easy way to fix this: #1294
Please advise if there is any better way.