fix(worker): return this.closing when calling close

[manast]

No description provided.

[onehorsetown]

Thanks. I was just about to submit a PR for this w/ one additional change.

Look at where the promise created in Worker.close calls super.close()

bullmq/src/classes/worker.ts

Line 381 in b68c845

await super.close();

QueueBase.close overwrites this.closing, thereby introducing a subtle bug.

Actually QueueBase.close itself has a bug where, if it is called twice, you end up overwriting the existing promise and end up closing the connection twice.

Perhaps QueueBase.close is better implemented as:

  close() {
    if (!this.closing) {
      this.closing = this.connection.close();
    }

    return this.closing;
  }

Which both prevents the connection from being closed twice and keeps the call to super.close in Worker.close from overwriting this.closing.

[manast]

🎉 This PR is included in version 1.8.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[manast]

🎉 This PR is included in version 1.8.14 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀