Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of trial and error on why connection errors don't seem to get retried (#2542), I found this to be the culprit.
You can verify it with the following script. Start running it, then kill your redis instance.
redis.asyncio.retry
it will not crash and restart pinging when redis comes backredis.retry
it will crashUnfortunately, there's no proper type checking for
kwargs
inredis.from_url
. I only found out about the difference by playing with theRedis
constructor and there it yelled at me that the types forretry
are incompatible.