Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: protect emit calls with throw/catch #697

Merged
merged 3 commits into from
Aug 23, 2021
Merged

fix: protect emit calls with throw/catch #697

merged 3 commits into from
Aug 23, 2021

Conversation

manast
Copy link
Contributor

@manast manast commented Aug 22, 2021

fixes #596

roggervalf
roggervalf approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@roggervalf roggervalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manast manast merged commit 1b59884 into master Aug 23, 2021
@manast manast deleted the fix/protect-emit-calls branch August 23, 2021 14:24
@github-actions
Copy link

🎉 This PR is included in version 1.42.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roggervalf roggervalf roggervalf approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[exiting] Fatal exception: Missing lock for job err
2 participants
@manast @roggervalf