Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Upgrade to latest zendesk chat and messaging sdk versions #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,19 @@ compile project(':react-native-zendesk-chat')
// Call this once in your Activity's bootup lifecycle
Chat.INSTANCE.init(mReactContext, key, appId);
```
## Troubleshoting
In Android, syncing gradle files fails to resolve zendesk libraries.
So, it requires to add the following in `android/build.gradle` file of your project:

```gradle
allprojects {
repositories {
maven {
url 'https://zendesk.jfrog.io/zendesk/repo'
}
}
}
```

## Contributing

Expand Down
49 changes: 25 additions & 24 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,42 +1,43 @@
apply plugin: 'com.android.library'

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}
def zendeskChatVersion = '3.4.0'
def zendeskMessagingVersion = '5.4.0'

buildscript {
repositories {
jcenter()
google()
}

dependencies {
classpath 'com.android.tools.build:gradle:3.2.1'
}
repositories {
mavenCentral()
google()
}
dependencies {
classpath 'com.android.tools.build:gradle:7.2.2'
}
}

android {
compileSdkVersion safeExtGet('compileSdkVersion', 28)
buildToolsVersion safeExtGet('buildToolsVersion', "28.0.3")

android {
compileSdkVersion safeExtGet('compileSdkVersion', 33)
buildToolsVersion safeExtGet('buildToolsVersion', '33.0.0')
defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 28)
versionCode 1
versionName "1.0"
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 28)
versionCode 1
versionName "1.0"
}
}

repositories {
mavenCentral()
jcenter()
google()
maven { url 'https://zendesk.jfrog.io/zendesk/repo' }
mavenCentral()
google()
maven {
url 'https://zendesk.jfrog.io/zendesk/repo'
}
}

dependencies {
implementation "com.facebook.react:react-native:+"

api group: 'com.zendesk', name: 'chat', version: safeExtGet('zendeskChatVersion', '3.1.0')
api group: 'com.zendesk', name: 'messaging', version: safeExtGet('zendeskMessagingVersion', '5.1.0')
implementation "com.facebook.react:react-native:+"
implementation group: 'com.zendesk', name: 'chat', version: zendeskChatVersion
implementation group: 'com.zendesk', name: 'messaging', version: zendeskMessagingVersion
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.ReadableType;
import com.facebook.react.bridge.WritableNativeMap;
import com.zendesk.service.ErrorResponse;
import com.zendesk.service.ZendeskCallback;

import java.util.ArrayList;

import zendesk.chat.Account;
import zendesk.chat.AccountStatus;
Expand All @@ -23,17 +27,12 @@
import zendesk.chat.ChatState;
import zendesk.chat.ObservationScope;
import zendesk.chat.Observer;
import zendesk.chat.ProfileProvider;
import zendesk.chat.PreChatFormFieldStatus;
import zendesk.chat.ProfileProvider;
import zendesk.chat.PushNotificationsProvider;
import zendesk.chat.VisitorInfo;
import zendesk.messaging.MessagingActivity;
import zendesk.messaging.MessagingConfiguration;
import com.zendesk.service.ErrorResponse;
import com.zendesk.service.ZendeskCallback;

import java.lang.String;
import java.util.ArrayList;
import zendesk.classic.messaging.MessagingActivity;
import zendesk.classic.messaging.MessagingConfiguration;

public class RNZendeskChatModule extends ReactContextBaseJavaModule {
private static final String TAG = "[RNZendeskChatModule]";
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"license": "MIT",
"devDependencies": { "prettier": "2.0.x", "eslint": "7.3.x" },
"peerDependencies": {
"react": "^16.11.0",
"react-native": "0.60.x | 0.61.x | 0.62.x | 0.63.x"
"react": "*",
"react-native": "*"
}
}