Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show "Improve Tasks" preference in F-Droid build #1981

Merged
merged 1 commit into from Aug 30, 2022

Conversation

cketti
Copy link
Contributor

@cketti cketti commented Aug 30, 2022

Preference instances that were not direct children of the Fragment's root PreferenceScreen were not removed. This lead to e.g. the "Improve Tasks" preference being shown in the F-Droid build.

Before and after:

tasks_settings_before tasks_settings_after

Preference instances that were not direct children of the Fragment's root PreferenceScreen were not removed.
@abaker abaker merged commit 468d42e into tasks:main Aug 30, 2022
@abaker
Copy link
Member

abaker commented Aug 30, 2022

Thanks!

@cketti cketti deleted the fix_remove_preferences branch August 30, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants