-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup foundations for packaging and publishing #39
Conversation
uses: pypa/gh-action-pypi-publish@master | ||
with: | ||
user: __token__ | ||
password: ${{ secrets.pypi_token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a token to be added as a GitHub secret
@@ -52,7 +52,7 @@ See [Running as Python script](#running-as-python-script) for more details. | |||
|
|||
| File | Description | | |||
|:-------------------------|:------------------------------------------------------------------------| | |||
| `build` | contains files to build executables | | |||
| `build-executables` | contains files to build executables | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to move it as build
is used for packaging :/
it does... a lot of other work with the start of the new year, be patient for eval |
No rush - let me know if you need anything explained 👍🏼 |
overwrites locals
@@ -1,5 +0,0 @@ | |||
/.venv/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These ignores are here to avoid polluting and accidentally committing invalid things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know - but overwrites already existing local ones. Your excludes are not other people excludes :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow? This is scoped to the repository? If anyone was to checkout the project and run make build
for example they would have buiild/
and dist/
folders showing as a change with git and would be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that but how to handle if my working dir contains a different .gitignore? anyway I took now more than 4 hours to try to get it work pypi for both branch for a simple python script file without a result, that was the reason why I used to think of pypi as a single simple python as an overkill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would your git repo contain a different .gitignore
? Normally these kind of things are scoped to the project so everyone has the same setup. With the exception of global ones which feel like a bit like an anti-pattern to me.
What were/are you struggling with?
My rational for this is to ease install and upgrades. Either with pure pip
or by leveraging pipx
e.g. with pipx it would be pipx install decode-config
and pipx upgrade decode-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To understand the current action status:
The last failed action basically is a result of the updated github release.
I updated release v12.3.0 to v12.3.1 which causes the error creating of the pypi packages using 12.3.0 which already exist.
cause github release update action didn't work, I downgraded release v12.3.1 to v12.3.0 and created a new release v12.3.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand the action is only invoked when the release is published and is based off the new existing tag that it was created on.
so if you had a draft release and updated it, as soon as you publish it that's what it will be based on.
I'm not sure what happens if you update an already published release though - is that what the problem came from updating an already published release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exactly, when you update an already published release (that's possible), then the github source file packages are updated but the action access an outdated tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to reproduce the issue on a new repo
- created release (CI kicked off)
- Update release (name + tag) - CI not kicked off
How did you get yours working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same steps as yours but different yml (publish.yml from this repo) from your Init PR - that's why I'm asking
To test local flow
Resolves #38