Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More/better TFMs #18

Merged
merged 2 commits into from
Oct 4, 2021
Merged

More/better TFMs #18

merged 2 commits into from
Oct 4, 2021

Conversation

AArnott
Copy link
Contributor

@AArnott AArnott commented Oct 3, 2021

Per #17, the latest nuget.org package targets net20 (.NET Framework 2.0). But the latest source in the repo dropped support for that and added netstandard1.3 instead.
Before we push the latest version of the package to nuget.org to address the .NET Core users out there, this PR brings back net20 support.

It also adds netstandard2.0, which is preferable since it brings in fewer facade assemblies.
It also adds test execution on .NET Framework, whereas before it only tested on .NET 5.

- Test on .NET Framework as well as .NET 5.
- Bring back .NET Framework 2.0 support.
- Target netstandard2.0 (as well as netstandard1.3) because the facade assemblies fall away and it's more performant in big apps.
@taspeotis
Copy link
Owner

Hey, I really appreciate the contribution to make this happen. I will see if I can get this building through GitHub Actions but, at a minimum, published to NuGet.

Do you mind if I add you as a contributor in the README?

@AArnott
Copy link
Contributor Author

AArnott commented Oct 3, 2021

Sounds good. Thank you.

@taspeotis
Copy link
Owner

I'll update the README and GitHub Actions later but for now:

Thanks to this contribution this issue is resolved.

NuGet is indexing a v2.0.1 of DeltaCompressionDotNet that targets:

  • .NET Framework 2.0
  • .NET Standard 1.3
  • .NET Standard 2.0

Thank you for making the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants