Backbone+Require app improvements

- Cleanup - Code style - Fix bug with removing todo after editing and the todo is empty - Update dependencies
tastejs · Aug 1, 2012 · a7a4d9c · a7a4d9c
1 parent 5995093
commit a7a4d9c
Show file tree

Hide file tree

Showing 20 changed files with 478 additions and 2,199 deletions.
diff --git a/dependency-examples/backbone_require/index.html b/dependency-examples/backbone_require/index.html
@@ -3,9 +3,13 @@
 <head>
 	<meta charset="utf-8">
 	<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
-	<title>Backbone.js</title>
+	<title>Backbone.js + RequireJS • TodoMVC</title>
 	<link rel="stylesheet" href="../../assets/base.css">
-	<script data-main="js/main" src="js/libs/require/require.js"></script>
+	<script src="../../assets/base.js"></script>
+	<script data-main="js/main" src="js/lib/require/require.js"></script>
+	<!--[if IE]>
+	<script src="../../assets/ie.js"></script>
+	<![endif]-->
 </head>
 <body>
 	<section id="todoapp">
@@ -26,4 +30,4 @@ <h1>todos</h1>
 		<p>Part of <a href="http://todomvc.com">TodoMVC</a></p>
 	</footer>
 </body>
-</html>
+</html>
diff --git a/dependency-examples/backbone_require/js/collections/todos.js b/dependency-examples/backbone_require/js/collections/todos.js
@@ -3,40 +3,41 @@ define([
 	'backbone',
 	'lib/backbone/localstorage',
 	'models/todo'
-	], function(_, Backbone, Store, Todo){
+], function( _, Backbone, Store, Todo ) {
 
 	var TodosCollection = Backbone.Collection.extend({
-
 		// Reference to this collection's model.
 		model: Todo,
 
 		// Save all of the todo items under the `"todos"` namespace.
-		localStorage: new Store("todos-backbone"),
+		localStorage: new Store('todos-backbone'),
 
 		// Filter down the list of all todo items that are finished.
 		completed: function() {
-			return this.filter(function(todo){ return todo.get('completed'); });
+			return this.filter(function( todo ) {
+				return todo.get('completed');
+			});
 		},
 
 		// Filter down the list to only todo items that are still not finished.
 		remaining: function() {
-			return this.without.apply(this, this.completed());
+			return this.without.apply( this, this.completed() );
 		},
 
 		// We keep the Todos in sequential order, despite being saved by unordered
 		// GUID in the database. This generates the next order number for new items.
 		nextOrder: function() {
-			if ( !this.length ){
+			if ( !this.length ) {
 				return 1;
 			}
 			return this.last().get('order') + 1;
 		},
 
 		// Todos are sorted by their original insertion order.
-		comparator: function(todo) {
+		comparator: function( todo ) {
 			return todo.get('order');
 		}
-
 	});
-	return new TodosCollection;
+
+	return new TodosCollection();
 });
diff --git a/dependency-examples/backbone_require/js/common.js b/dependency-examples/backbone_require/js/common.js
@@ -1,12 +1,9 @@
-define([], function(){
-
+define([], function() {
 	return {
 		// Which filter are we using?
-		TodoFilter: "",  // empty, active, completed
+		TodoFilter: '', // empty, active, completed
 
 		// What is the enter key constant?
 		ENTER_KEY: 13
 	};
-
 });
-
diff --git a/...bone_require/js/libs/backbone/backbone.js → ...kbone_require/js/lib/backbone/backbone.js b/...bone_require/js/libs/backbone/backbone.js → ...kbone_require/js/lib/backbone/backbone.js
diff --git a/dependency-examples/backbone_require/js/lib/backbone/localstorage.js b/dependency-examples/backbone_require/js/lib/backbone/localstorage.js
diff --git a/dependency-examples/backbone_require/js/lib/jquery/jquery.min.js b/dependency-examples/backbone_require/js/lib/jquery/jquery.min.js
diff --git a/dependency-examples/backbone_require/js/lib/require/require.js b/dependency-examples/backbone_require/js/lib/require/require.js