Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use built maria.js file and organize files according to framework's recommended best practices #187

Merged
merged 1 commit into from Jul 1, 2012

Conversation

petermichaux
Copy link
Contributor

use built maria.js file and organize files according to framework's recommended best practices

Fixes #183

@petermichaux
Copy link
Contributor Author

I didn't change any code with this pull request other than some relative URLs in index.html. This is just a replacement of all the many individual source files of the Maria code with a single built/concatenated file and a reorganization of the files.

@addyosmani
Copy link
Member

Thanks Peter! We appreciate your time on this. We'll review and let you
know if this is good for a merge.

On Sunday, 17 June 2012, Peter Michaux wrote:

use built maria.js file and organize files according to framework's
recommended best practices

You can merge this Pull Request by running:

git pull https://github.com/petermichaux/todomvc master

Or you can view, comment on it, or merge it online at:

#187

-- Commit Summary --

  • use built maria.js file and organize files according to framework's
    recommended best practices

-- File Changes --

D labs/architecture-examples/maria/lib/arbutus/arbutus-min.js (17)
D labs/architecture-examples/maria/lib/arbutus/arbutus.js (111)
D labs/architecture-examples/maria/lib/buster/buster-test.css (201)
D labs/architecture-examples/maria/lib/buster/buster-test.js (7271)
D labs/architecture-examples/maria/lib/evento/evento-min.js (33)
D labs/architecture-examples/maria/lib/evento/evento.js (535)
D labs/architecture-examples/maria/lib/grail/grail-min.js (29)
D labs/architecture-examples/maria/lib/grail/grail.js (186)
D labs/architecture-examples/maria/lib/hijos/hijos-min.js (28)
D labs/architecture-examples/maria/lib/hijos/hijos.js (379)
D labs/architecture-examples/maria/lib/hormigas/hormigas-min.js (25)
D labs/architecture-examples/maria/lib/hormigas/hormigas.js (445)
A labs/architecture-examples/maria/lib/maria/maria.js (2635)
D labs/architecture-examples/maria/src/Controller.js (29)
D labs/architecture-examples/maria/src/Controller.subclass.js (1)
D labs/architecture-examples/maria/src/ElementView.js (79)
D labs/architecture-examples/maria/src/ElementView.subclass.js (39)
D labs/architecture-examples/maria/src/Model.js (114)
D labs/architecture-examples/maria/src/Model.subclass.js (44)
D labs/architecture-examples/maria/src/SetModel.js (271)
D labs/architecture-examples/maria/src/SetModel.subclass.js (49)
D labs/architecture-examples/maria/src/SetView.js (61)
D labs/architecture-examples/maria/src/SetView.subclass.js (1)
D labs/architecture-examples/maria/src/View.js (85)
D labs/architecture-examples/maria/src/View.subclass.js (28)
D labs/architecture-examples/maria/src/borrow.js (7)
D labs/architecture-examples/maria/src/borrowArbutus.js (1)
D labs/architecture-examples/maria/src/borrowEvento.js (1)
D labs/architecture-examples/maria/src/borrowGrail.js (1)
D labs/architecture-examples/maria/src/borrowHijos.js (1)
D labs/architecture-examples/maria/src/borrowHormigas.js (1)
A labs/architecture-examples/maria/src/css/todos.css (0)
D labs/architecture-examples/maria/src/header.js (7)
R labs/architecture-examples/maria/src/index.html (30)
A labs/architecture-examples/maria/src/js/bootstrap.js (0)
A labs/architecture-examples/maria/src/js/controllers/TodoController.js (0)
A
labs/architecture-examples/maria/src/js/controllers/TodosInputController.js
(0)
A
labs/architecture-examples/maria/src/js/controllers/TodosToolbarController.js
(0)
A labs/architecture-examples/maria/src/js/models/TodoModel.js (0)
A labs/architecture-examples/maria/src/js/models/TodosModel.js (0)
A labs/architecture-examples/maria/src/js/namespace.js (0)
A labs/architecture-examples/maria/src/js/templates/TodoTemplate.js (0)
A labs/architecture-examples/maria/src/js/templates/TodosAppTemplate.js (0)
A labs/architecture-examples/maria/src/js/templates/TodosInputTemplate.js
(0)
A labs/architecture-examples/maria/src/js/templates/TodosListTemplate.js
(0)
A labs/architecture-examples/maria/src/js/templates/TodosStatsTemplate.js
(0)
A
labs/architecture-examples/maria/src/js/templates/TodosToolbarTemplate.js
(0)
A labs/architecture-examples/maria/src/js/views/TodoView.js (0)
A labs/architecture-examples/maria/src/js/views/TodosAppView.js (0)
A labs/architecture-examples/maria/src/js/views/TodosInputView.js (0)
A labs/architecture-examples/maria/src/js/views/TodosListView.js (0)
A labs/architecture-examples/maria/src/js/views/TodosStatsView.js (0)
A labs/architecture-examples/maria/src/js/views/TodosToolbarView.js (0)
D labs/architecture-examples/maria/src/namespace.js (1)
D labs/architecture-examples/maria/src/subclass.js (19)

-- Patch Links --

https://github.com/addyosmani/todomvc/pull/187.patch
https://github.com/addyosmani/todomvc/pull/187.diff


Reply to this email directly or view it on GitHub:
#187

Addy Osmani

Developer Programs Engineer at Google
Blogger at: http://addyosmani.com
Phone: +44 7501 594 382

@petermichaux
Copy link
Contributor Author

Hi Addy,

This pull request is just a start. After things are organized with this pull request, the app can then be refined to satisfy requirements.

@addyosmani
Copy link
Member

@petermichaux awesome!. I'm hoping for us to wrap up our next release within the next week or so. Do you think you might have a chance to get any more changes in before then? Would absolutely love for Maria to be one of our stable/complete 1.0 apps.

@petermichaux
Copy link
Contributor Author

If this pull request is accepted then I can start work on the next one.

sindresorhus added a commit that referenced this pull request Jul 1, 2012
use built maria.js file and organize files according to framework's recommended best practices
@sindresorhus sindresorhus merged commit b5adebe into tastejs:master Jul 1, 2012
@sindresorhus
Copy link
Member

@petermichaux Done ;)

We're shooting for a release on the 9th, would be awesome if you could get in some updates by then.

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this pull request Dec 23, 2013
use built maria.js file and organize files according to framework's recommended best practices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maria.js implementation
3 participants