#475 - puremvc updated with bower. #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| <meta charset="utf-8"> | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1"> | |||
| <title>PureMVC • TodoMVC</title> | |||
| <link rel="stylesheet" href="../../../assets/base.css"> | |||
| <link rel="stylesheet" href="components/todomvc-common/base.css"> | |||
| <!--[if IE]> | |||
| <script src="assets/ie.js"></script> | |||
| <![endif]--> | |||
There was a problem hiding this comment.
Could you also remove the IE block?
|
Woops! Of course. I skipped sleeping last night in favor of playing with Sammy. That sounded a little weird. Fix coming right up! |
|
All set. |
passy
added a commit
that referenced
this pull request
Apr 3, 2013
#475 - puremvc updated with bower.
|
Fantastic. Thank you! |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
tastejs#475 - puremvc updated with bower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #475 - updated PureMVC to use bower, and point to the right files from index.html.
Also caught a small bug. The script was adding a class of
completeon a completed li, where it wanted acompleted. Added that in, and it all seems to be working well!