Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] New react-backbone todomvc with fixes and React version bump #857

Merged
merged 1 commit into from Feb 21, 2014

Conversation

chenglou
Copy link
Contributor

Like #855, bumped React version (along with all the other deps) and made some fixes.

I ran the e2e test and it passes all. I don't care as much for pulling react-backbone out of the labs, but I was wondering if we could include it in the tests by removing it from the exclusions list in allTests.js.

Like tastejs#855, bumped React version (along with all the other deps) and made
some fixes.
sindresorhus added a commit that referenced this pull request Feb 21, 2014
[React] New react-backbone todomvc with fixes and React version bump
@sindresorhus sindresorhus merged commit b8ceb31 into tastejs:gh-pages Feb 21, 2014
@sindresorhus
Copy link
Member

Awesome. Thanks :)

was wondering if we could include it in the tests by removing it from the exclusions list in allTests.js.

@ColinEberhardt ?

@ColinEberhardt
Copy link
Member

was wondering if we could include it in the tests by removing it from the exclusions list in allTests.js.

No problem #860 - good to see all the tests now pass :-)

@chenglou chenglou deleted the react-bb branch February 21, 2014 21:39
@jtrunick
Copy link

jtrunick commented Mar 5, 2014

Couldn't find any backbone code. in the example.
http://todomvc.com/labs/architecture-examples/react-backbone/
takes you to pure React code AFAICT

@chenglou
Copy link
Contributor Author

chenglou commented Mar 5, 2014

@jtrunick how come? I'm checking the page and it shows Backbone code. Most of it is used in todo.js and todos.js

@jtrunick
Copy link

jtrunick commented Mar 5, 2014

This is where it takes me when i click on "Source"
https://github.com/tastejs/todomvc/tree/gh-pages/architecture-examples/react
Under the js directory there is no files called todo.js and todos.js.
I suspect the link from todosmvc.com is wrong (as it simply says "/react" in the url). Could you give me the correct link

@chenglou
Copy link
Contributor Author

chenglou commented Mar 5, 2014

Ah, right. Thanks!
#869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants